Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect “all toggles are off” message #104

Closed
vdhamer opened this issue Jan 2, 2023 · 0 comments
Closed

Incorrect “all toggles are off” message #104

vdhamer opened this issue Jan 2, 2023 · 0 comments
Assignees
Labels
Bug Something isn't working

Comments

@vdhamer
Copy link
Owner

vdhamer commented Jan 2, 2023

Reproduce using:

  1. Select only Aspiring members (or any category with only a few entries)
  2. Temporarily remove these entries in Portfolios screen (swipe left)

Now the list of displayed members should be empty. But the text (at the bottom of the empty list of Portfolios) says this is because all settings are disabled. This is incorrect: there are settings enabled, but there is no data that matches the filter criteria. Fix logic (or text message).

Actually the code looks correct, so maybe this is just a translation to NL problem:

if fetchRequest.nsPredicate == NSPredicate.none {
        Text("""
             Warning: all member categories on the Preferences page are disabled. \
             Please enable one or more options in Preferences.
             """, comment: "Hint to the user if all of the Preference toggles are disabled.")

English version was fine. Was a misleading translation.

@vdhamer vdhamer added the Bug Something isn't working label Jan 2, 2023
@vdhamer vdhamer closed this as completed in b242854 Jan 2, 2023
@vdhamer vdhamer self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant