Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make state of locks on PhotoClubs page persistent #75

Closed
vdhamer opened this issue Dec 14, 2022 · 1 comment
Closed

Make state of locks on PhotoClubs page persistent #75

vdhamer opened this issue Dec 14, 2022 · 1 comment
Assignees
Labels
Bug Something isn't working Enhancement New feature or request

Comments

@vdhamer
Copy link
Owner

vdhamer commented Dec 14, 2022

Currently, the state is lost after then app (really) closes. This is not expected behavior for an - admittedly very minor - user preference setting.

Note that lock state is currently configurable per PhotoClub, and that the set of supported Photo Clubs should ultimately be determined at runtime (=dynamcally).

Possible solutions:

  1. store Lock state in UserDefaults as a dictionary. The dictionary can grow.
  2. store Lock state in UserDefaults as a Boolean. Means all locks open/close together. User won’t really mind or notice. But there are multiple separate Lock buttons.
  3. store state in existing Core Data database. There is already a PhotoClubs table, so just requires one extra property, and the ability to get is (no effort) and set it (some code).

In all cases, the state of the Lock is lost when the app is reinstalled. I implemented option 3.

@vdhamer vdhamer self-assigned this Dec 14, 2022
@vdhamer vdhamer pinned this issue Dec 18, 2022
@vdhamer vdhamer unpinned this issue Dec 28, 2022
@vdhamer vdhamer pinned this issue Dec 29, 2022
@vdhamer vdhamer unpinned this issue Dec 30, 2022
@vdhamer vdhamer pinned this issue Jan 3, 2023
@vdhamer vdhamer added Enhancement New feature or request In progress Being worked on Bug Something isn't working labels Jan 22, 2023
@vdhamer
Copy link
Owner Author

vdhamer commented Jan 22, 2023

Actually the Lock is (in theory) buggy in v2.2.8: if you lock/unlock a photo club's map when there are 2 clubs with the same name in a different town, both lock/unlock together. This won't bother anyone yet, but should be resolved as part of issue #75.

@vdhamer vdhamer unpinned this issue Jan 29, 2023
@vdhamer vdhamer closed this as completed Jan 29, 2023
@vdhamer vdhamer removed the In progress Being worked on label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant