Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some confusions about convert_to_head.py #27

Closed
leileilin opened this issue Jul 19, 2022 · 14 comments
Closed

some confusions about convert_to_head.py #27

leileilin opened this issue Jul 19, 2022 · 14 comments

Comments

@leileilin
Copy link

leileilin commented Jul 19, 2022

Hello, I have a new question about convert_ to_ heads.py file, in which some span and clusters will be deleted.
Is this the case as follows?
In those cases "A" and "A & B" are different spans with the same head word, "A".
In our implementation such cases were simply discarded from the training set, because they were few and we were able to perform well, even though we couldn't predict any of such cases during inference.
like u said in #2
thanks.

@vdobrovolskii
Copy link
Owner

I am sorry, I don't quite understand your question.
Are you asking if what I said in issue #2 is true? Yes, it is

@leileilin
Copy link
Author

I am sorry, I don't quite understand your question. Are you asking if what I said in issue #2 is true? Yes, it is

I mean the deleted span and clusters in convert_to_head.py is the same as the above example i proposed?

@vdobrovolskii
Copy link
Owner

What example are you referring to?

@leileilin
Copy link
Author

In those cases "A" and "A & B" are different spans with the same head word, "A".
In our implementation such cases were simply discarded from the training set, because they were few and we were able to perform well, even though we couldn't predict any of such cases during inference.

In those cases "A" and "A & B" are different spans with the same head word, "A".
In our implementation such cases were simply discarded from the training set, because they were few and we were able to perform well, even though we couldn't predict any of such cases during inference.
it is the example you refered to in #2 .

@vdobrovolskii
Copy link
Owner

But what do you want me to say? You are quoting me to myself, do I need to additionally confirm what I said is still true? Or what? 😆

@leileilin
Copy link
Author

But what do you want me to say? You are quoting me to myself, do I need to additionally confirm what I said is still true? Or what? 😆

what i want to say is the deleted span and clusters in convert_to_head.py is the same as the above example i proposed?
i know the example is true but the relationship between them is not certain for me. 😆

@vdobrovolskii
Copy link
Owner

You mean, is there any difference between deleting a span and deleting a cluster?
Or you are talking about the variables deleted_spans and deleted_clusters in convert_to_heads.py?

@leileilin
Copy link
Author

You mean, is there any difference between deleting a span and deleting a cluster? Or you are talking about the variables deleted_spans and deleted_clusters in convert_to_heads.py?

I mean, I don't know the basis for deleting span and clusters in convert_to_head.py? is the same as the example above?

@leileilin
Copy link
Author

You mean, is there any difference between deleting a span and deleting a cluster? Or you are talking about the variables deleted_spans and deleted_clusters in convert_to_heads.py?

I mean, I don't know the basis for deleting span and clusters in convert_to_head.py? is the same as the example above?

simplly to say , according to what to delete span and cluster in convert_to_head.py?

@vdobrovolskii
Copy link
Owner

Yes, according to that you would delete spans.
And then all the singleton clusters also get deleted.

@leileilin
Copy link
Author

Yes, according to that you would delete spans. And then all the singleton clusters also get deleted.

in other words, if "A" and "A & B" are different spans with the same head word, "A". so "A & B" will be deleted.
right ?

@vdobrovolskii
Copy link
Owner

yes

@leileilin
Copy link
Author

yes

If I don't delete it, can I train with such a dataset?

@vdobrovolskii
Copy link
Owner

You can, but it will be suboptimal (you will have the same head point to differen spans in span predictor module). And you will need to merge unrelated clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants