Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Send image with default size" box shouldn't be an option for gifs #1254

Closed
Cadair opened this issue Apr 19, 2020 · 2 comments 路 Fixed by #2475
Closed

"Send image with default size" box shouldn't be an option for gifs #1254

Cadair opened this issue Apr 19, 2020 · 2 comments 路 Fixed by #2475
Assignees
@bmarty
Labels
A-Media T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 17

Comments

@Cadair
Copy link
Contributor

Cadair commented Apr 19, 2020

If you don't tick the box when sending a gif it gets resized and turned into a still not an animated image. Unless the resizer can handle the gif it shouldn't be an option to de-gif it 馃榿
@bmarty bmarty added A-Media T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Apr 22, 2020
@colalord
Copy link

colalord commented Sep 5, 2020

Any update on this? It still seems to be an issue.

@bmarty bmarty self-assigned this Dec 1, 2020
@bmarty bmarty added this to the Sprint 17 milestone Dec 1, 2020
@bmarty
Copy link
Member

bmarty commented Dec 1, 2020

I'm fixing that. The option to send with original size is still there but will be applied only to static image.

bmarty added a commit that referenced this issue Dec 1, 2020
@bmarty
Do not compress GIFs (#1616, #1254)
c213306
@bmarty bmarty mentioned this issue Dec 1, 2020
Merged
bmarty added a commit that referenced this issue Dec 11, 2020
@bmarty
Do not compress GIFs (#1616, #1254)
21271b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Media T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 17
Development

Successfully merging a pull request may close this issue.

Feature/bma/gif from keyboard preview element-hq/element-android
3 participants
@Cadair @bmarty @colalord