Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a way to enter an URL in the SSO screen. #1400

Closed
bmarty opened this issue May 25, 2020 · 2 comments · Fixed by #1451
Closed

We need a way to enter an URL in the SSO screen. #1400

bmarty opened this issue May 25, 2020 · 2 comments · Fixed by #1451
Assignees
Labels
A-SSO Z-Mozilla Mozilla feedback

Comments

@bmarty
Copy link
Member

bmarty commented May 25, 2020

When connecting to RiotX using SSO, for instance using mozilla.modular.im, if user choose to enter an email and click "Enter" here:

image

He receives an email with a link which has to be open in the same webview.

Extract of the e-mail content:

Click and confirm that you want to sign in to mozilla.modular.im. Please sign in using the same web browser that you used to generate this link. The link will expire in fifteen minutes.

and a URL to click or copy

But currently there is no way in RiotX to enter the received url.

@bmarty bmarty added Z-Mozilla Mozilla feedback A-SSO labels May 25, 2020
@auscompgeek
Copy link

I think instead of opening a webview, the SSO flow should open a real browser instead.

@bmarty
Copy link
Member Author

bmarty commented May 25, 2020

We are using a Webview because there is a Javascript bridge to the app to send the credentials back.

EDIT: This above is not true anymore in case of SSO login.

#1451 fixes this issue by opening SSO page to an external browser (or in custom tabs if available

@bmarty bmarty self-assigned this Jun 4, 2020
bmarty added a commit that referenced this issue Jun 4, 2020
Use ChromeCustomTabs to host the SSO web page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSO Z-Mozilla Mozilla feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants