Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/register response handling is outdated #1443

Closed
timokoesters opened this issue Jun 3, 2020 · 1 comment · Fixed by #1448
Closed

/register response handling is outdated #1443

timokoesters opened this issue Jun 3, 2020 · 1 comment · Fixed by #1448
Assignees
@bmarty

Comments

@timokoesters
Copy link
Contributor

RiotX seems to expect that the server responds with a home_server field, but that's deprecated in the spec.
@bmarty bmarty self-assigned this Jun 4, 2020
bmarty added a commit that referenced this issue Jun 4, 2020
@bmarty
Make Credentials.homeServer optional because it is deprecated (#1443)
8b7e5e5 
It is never used currently in RiotX, but if homeserver does not sent it, it would crash.
@bmarty bmarty mentioned this issue Jun 4, 2020
Merged
@bmarty
Copy link
Member

bmarty commented Jun 4, 2020

Thanks, fixed in #1448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fix element-hq/element-android
2 participants
@bmarty @timokoesters