Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read config.xml file from Riot web client #1682

Closed
bmarty opened this issue Jul 13, 2020 · 0 comments · Fixed by #1945
Closed

Read config.xml file from Riot web client #1682

bmarty opened this issue Jul 13, 2020 · 0 comments · Fixed by #1945
Assignees
Labels

Comments

@bmarty
Copy link
Member

bmarty commented Jul 13, 2020

When the user enters a homeserver url, he can actually enter a Riot web client url, and RiotX will retrieve the default homeserver from the config file.

But the work is not complete.

Riot-Web impl: https://github.com/vector-im/riot-web/blob/eac86b60536cbcf421f90bff30e1d21cd0a90c00/src/vector/app.tsx#L184-L236

in summary, choose first applicable of:

use `default_hs_url` [& `default_is_url`] if available
use `default_server_config` if available
use `default_server_name` if available

For the moment, RiotX only looks at default_hs_url, so it does not work for instance for https://riot.im/app

Code: https://github.com/vector-im/riotX-android/blob/5f540a5b45dd1fe32354ece35c2c00a3bafe6aa0/matrix-sdk-android/src/main/java/im/vector/matrix/android/internal/auth/data/RiotConfig.kt#L27

Ref: https://github.com/vector-im/riot-web/blob/develop/docs/config.md

Also another thing to consider is that Riot web reads two config.json files config.$domain.json if exists, otherwise config.json (where $domain is the riot domain e.g chat.mozilla.org)

@bmarty bmarty self-assigned this Aug 17, 2020
bmarty added a commit that referenced this issue Aug 17, 2020
bmarty added a commit that referenced this issue Aug 17, 2020
bmarty added a commit that referenced this issue Aug 17, 2020
@bmarty bmarty linked a pull request Aug 17, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant