Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it harder to accidentally call someone #1869

Closed
clarfonthey opened this issue Aug 3, 2020 · 4 comments · Fixed by #1883
Closed

Make it harder to accidentally call someone #1869

clarfonthey opened this issue Aug 3, 2020 · 4 comments · Fixed by #1883
Assignees

Comments

@clarfonthey
Copy link

clarfonthey commented Aug 3, 2020

Every other app immediately starts a call when pressing the button. I can't count the number of times I've seen someone accidentally press the button and start a call.

We can do better here and show a confirmation before starting the call so that it's harder to accidentally start a call when you're messaging someone. Alternatively, the option can be under a three-dot menu to make it harder to do accidentally.

@TR-SLimey
Copy link
Contributor

Good idea, but needs to be done right in order to not be annoying. People used to just tapping and calling will probably get frustrated with this. I think putting the call button within a 3-dot menu at the top of the chat room is a good idea, because it will get rid of the "quick action" feel and users then won't expect to call instantly but rather go though some steps. A confirmation can then also be added.

@clarfonthey clarfonthey changed the title Confirmation before starting calls Make it harder to accidentally call someone Aug 3, 2020
@clarfonthey
Copy link
Author

clarfonthey commented Aug 3, 2020

Good point, updated the issue to clarify the goal is to make accidental calls harder, and there are multiple ways to accomplish this.

@532910
Copy link
Contributor

532910 commented Aug 5, 2020

Call must be a one tap action!

@bmarty
Copy link
Member

bmarty commented Aug 5, 2020

The call button are at the top of screen, so it is hard to tap on it accidentally. And as you said, every other app start call immediately. On Riot-Android there was a confirmation dialog, so I will add a setting to add the dialog for users who really want to.

@bmarty bmarty self-assigned this Aug 5, 2020
bmarty added a commit that referenced this issue Aug 12, 2020
Give user the possibility to prevent accidental call (#1869)
@bmarty bmarty added this to the Post-Element release milestone Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants