Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users often accidentally ignore other users #1890

Closed
aaronraimist opened this issue Aug 7, 2020 · 4 comments · Fixed by #1900
Closed

Users often accidentally ignore other users #1890

aaronraimist opened this issue Aug 7, 2020 · 4 comments · Fixed by #1900
Assignees
@bmarty
Milestone
Post-Element release

Comments

@aaronraimist
Copy link

Describe the bug
I have seen a lot of reports of users accidentally ignoring other users recently. It seems like some confimation step or something should be added. Most of the reports are from people using both Element Web and Element Android so I'm not sure which client actually did the accidental ignore but it seems likely that it could be Element Android.

Related web issue: element-hq/element-web#14633

screenshot
@aaronraimist
Copy link
Author

Yeah it seems like if you press and hold on a message, there is no confirmation required if you tap "Block user" and there is also no indication that you blocked them. The "Block user" button doesn't even change to say "Unblock user" or anything.

This is a major issue. I have seen A LOT of people reporting this lately.

@aaronraimist aaronraimist changed the title User accidentally ignored another user Users often accidentally ignore other users Aug 10, 2020
@aaronraimist aaronraimist mentioned this issue Aug 10, 2020
Closed
@bmarty bmarty added this to the Sprint13 milestone Aug 11, 2020
@bmarty bmarty self-assigned this Aug 12, 2020
@bmarty bmarty modified the milestones: Sprint13, Post-Element release Aug 12, 2020
@bmarty
Copy link
Member

bmarty commented Aug 12, 2020

I add a confirmation dialog when ignoring a user from the bottom sheet.
I created #1899 for the remaining things to do

bmarty added a commit that referenced this issue Aug 12, 2020
@bmarty
Ensure users do not accidentally ignore other users (#1890)
2933734 
- Wording: use "Ignore" instead of "Block" for consistency across the app and with other Element app
@bmarty bmarty mentioned this issue Aug 12, 2020
Merged
bmarty added a commit that referenced this issue Aug 13, 2020
@bmarty
Ensure users do not accidentally ignore other users (#1890)
3103fe9 
- Wording: use "Ignore" instead of "Block" for consistency across the app and with other Element app
bmarty added a commit that referenced this issue Aug 13, 2020
@bmarty
Merge pull request #1900 from vector-im/feature/improve_ignore_user
87c903a 
Ensure users do not accidentally ignore other users (#1890)
@aaronraimist
Copy link
Author

aaronraimist commented Aug 19, 2020 •
edited

Is there a new version coming soon with this fix? This is biting a lot of users.

@EchedelleLR
Copy link

Is there a new version coming soon with this fix? This is biting a lot of users.

Version 1.0.5 already includes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
None yet
Projects
None yet
Milestone
Post-Element release
Development

Successfully merging a pull request may close this issue.

Ensure users do not accidentally ignore other users (#1890) element-hq/element-android
3 participants
@bmarty @aaronraimist @EchedelleLR