Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room date format is not correct for some Asian languages #1928

Closed
yh-gao opened this issue Aug 16, 2020 · 0 comments · Fixed by #1930
Closed

Room date format is not correct for some Asian languages #1928

yh-gao opened this issue Aug 16, 2020 · 0 comments · Fixed by #1930

Comments

@yh-gao
Copy link
Contributor

yh-gao commented Aug 16, 2020 •
edited

Describe the bug
The date format is not correct for some Asian languages:

Locale JP zh_CN zh_TW
Wrong Format 土 15 8月 周六 15 8月 週六 15 8月

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Settings" --> Preferences-->Languages
  2. Choose any Asian languages: 中文, or 日本语
  3. Kill and re-launch app
  4. Go to any room and may find date format

Expected behavior
https://en.wikipedia.org/wiki/Date_and_time_notation_in_Japan#:~:text=The%20most%20commonly%20used%20date,%22Wednesday%2031%20December%202008%22
The most commonly used date format in Japan is "year month day (weekday)", with the Japanese characters meaning "year", "month" and "day" inserted after the numerals. Example: 2008年12月31日 (水) for "Wednesday 31 December 2008".
Chinese date formats is similar as Japanese.
Correct date notations should be:

Locale JP zh_CN zh_TW
Expected Format 8月15日(土) 8月15日周六 8月15日週六

Screenshots
If applicable, add screenshots to help explain your problem.

Locale JP zh_CN
Wrong date format JP-date zh_CN-date

Smartphone (please complete the following information):

  • Device: [Pixel 3a]
  • OS: [Android 10]

Additional context

  • App version and store [1.0.5-dev Element Android]
  • Homeserver: [matrix.org]

Add any other context about the problem here.
yh-gao added a commit to yh-gao/element-android that referenced this issue Aug 16, 2020
@yh-gao
Fix relative format of some Asian languages (element-hq#1928)
fd085d9 
With DateFormat.getBestDateTimePattern to generate best
localized pattern.
yh-gao added a commit to yh-gao/element-android that referenced this issue Aug 16, 2020
@yh-gao
Fix relative format of some Asian languages (element-hq#1928)
5bb3c9d 
With DateFormat.getBestDateTimePattern to generate best
localized pattern.

Signed-off-by: Yihong Gao <yihong.ui@gmail.com>
yh-gao added a commit to yh-gao/element-android that referenced this issue Aug 16, 2020
@yh-gao
Fix date format of some Asian languages (element-hq#1928) element-hq#…
11650ca 
…1915

With DateFormat.getBestDateTimePattern to generate best
localized pattern.

Signed-off-by: Yihong Gao <yihong.ui@gmail.com>
yh-gao added a commit to yh-gao/element-android that referenced this issue Aug 16, 2020
@yh-gao
Fix date format of some Asian languages (element-hq#1928) element-hq#…
bc3bc99 
…1929

With DateFormat.getBestDateTimePattern to generate best
localized pattern.

Signed-off-by: Yihong Gao <yihong.ui@gmail.com>
yh-gao added a commit to yh-gao/element-android that referenced this issue Aug 16, 2020
@yh-gao
Fix date format of some Asian languages (element-hq#1928)
e3b7f16 
With DateFormat.getBestDateTimePattern to generate best
localized pattern.

Signed-off-by: Yihong Gao <yihong.ui@gmail.com>
@bmarty bmarty mentioned this issue Aug 17, 2020
Merged
6 tasks
@bmarty bmarty linked a pull request Aug 17, 2020 that will close this issue
Fix date format for some Asian languages (#1928) #1930
Merged
6 tasks
bmarty added a commit that referenced this issue Aug 17, 2020
@bmarty
Merge pull request #1930 from yh-gao/best_localized_date_format
a9ad3ac 
Fix date format for some Asian languages (#1928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix date format for some Asian languages (#1928) yh-gao/element-android
1 participant
@yh-gao