Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Kick appears has "someone has made no change" #1959

Closed
erdnaxeli opened this issue Aug 19, 2020 · 4 comments · Fixed by #1962
Closed

A Kick appears has "someone has made no change" #1959

erdnaxeli opened this issue Aug 19, 2020 · 4 comments · Fixed by #1962
Assignees

Comments

@erdnaxeli
Copy link

Describe the bug
Someone kicked someone else. On element android I see (in french) "Someone n'a effectué aucun changement" (which could be translated to "Someone has made no change") while on element web I see "Someone has kicked someone else".

To Reproduce
I am not sure, when I try to reproduce it the event is shown correctly.

Expected behavior
I expect element android to show me "Someone has kickes someone else".

Screenshots
2020-08-19-101831_603x92_scrot
Screenshot_20200819-101738

Smartphone (please complete the following information):

  • Device: Moto G4 Plus
  • OS: Android 8.1.0

Additional context

  • App version and store 1.0.4 on Playstore
  • Homeserver: cervoi.se

The user doing the kick is a bridged one from IRC, but I don't see why it would change anything.

@bmarty
Copy link
Member

bmarty commented Aug 19, 2020

Can you send the content of the Event please?

@bmarty bmarty self-assigned this Aug 19, 2020
@erdnaxeli
Copy link
Author

erdnaxeli commented Aug 19, 2020

Sure:

{
  "content": {
    "membership": "leave",
    "reason": "attention derrière toi ! "
  },
  "event_id": "$159782383733024WwvKp:iiens.net",
  "origin_server_ts": 1597823837042,
  "sender": "@irc_PrinceCaramel:iiens.net",
  "state_key": "@irc_Tuareg:iiens.net",
  "type": "m.room.member",
  "unsigned": {
    "prev_content": {
      "membership": "leave"
    },
    "prev_sender": "@irc_Tuareg:iiens.net",
    "replaces_state": "$15729348546465XXTuX:iiens.net",
    "age": 335970
  },
  "room_id": "!XOjaoEoAmGOyLzYKMD:iiens.net"
}

The previous event already being a leave might explain it.

@bmarty
Copy link
Member

bmarty commented Aug 19, 2020

The previous event already being a leave might explain it.

Indeed. I have no idea why Element Web is correct though

EDIT: oh, I see, the sender is not the same than the state_key. So I think we can improve our algorithm.

@erdnaxeli
Copy link
Author

erdnaxeli commented Aug 19, 2020

My guess is that the IRC bridge never make the user join, and element android and web have a different behavior with a leave -> leave event. I think I prefer the behavior of element web, but I am sur I don't like the element android one. "Nothing has changer" is really disturbing.

Btw this is not related to this issue but the IRC bridge should probably make a user join before kicking it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants