Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ringtone volume can not be changed while ringing #2246

Closed
lomion0815 opened this issue Oct 12, 2020 · 1 comment
Closed

Ringtone volume can not be changed while ringing #2246

lomion0815 opened this issue Oct 12, 2020 · 1 comment

Comments

@lomion0815
Copy link
Contributor

Describe the bug
For outgoing calls the volume of the ringtone can not be controlled by using the buttons on the phone. Reason is that in this state of the call (callState.Dialing) the buttons already control the conversation volume while the ringtone is played in the "media" context. When you open the volume dialog and change the media volume it affects the ringtone volume

To Reproduce
Steps to reproduce the behavior:

  1. Initiate call (e.g. video call in a DM chat)
  2. Press the volume button on the side of the smartphone

Expected behavior
Ringtone volume changes

Smartphone (please complete the following information):

  • Device: Samsung Galaxy A8
  • OS: Android 9

Additional context

  • App version and store G-Play 1.0.8
  • Homeserver: selfhosted
lomion0815 added a commit to lomion0815/element-android that referenced this issue Oct 12, 2020
@lomion0815
Fix for ticket element-hq#2246: Ringtone volume cannot bechanged whil…
a9f7fb4 
…e ringing

This fix delays the creation of the audioManager until the call is connected. This way the call feature does not takes the focus from the core service (where the ringtone is generated) until the call is esablished. This way the volume can be controled correctly while the phone is ringing (incoming and outgoing).
@lomion0815 lomion0815 mentioned this issue Oct 13, 2020
Merged
4 tasks
bmarty added a commit that referenced this issue Nov 2, 2020
@bmarty
Merge pull request #2174 from lomion0815/fix_2100_2
a50bd74 
Fix for #2100 and #2246:: Using Ringtone class to control ringtones for incoming calls.
@bmarty
Copy link
Member

bmarty commented Nov 2, 2020

Should be fixed by #2174 (Element 1.0.10)

@bmarty bmarty closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmarty @lomion0815