Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install APKs from chats #2381

Closed
RocketJannis opened this issue Nov 12, 2020 · 1 comment · Fixed by #3238
Closed

Install APKs from chats #2381

RocketJannis opened this issue Nov 12, 2020 · 1 comment · Fixed by #3238
Assignees
@bmarty
Labels
A-File-Download T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@RocketJannis
Copy link

RocketJannis commented Nov 12, 2020 •
edited

Is your feature request related to a problem? Please describe.
Sometimes I want to send an APK file to a friend so he can install it. If I click on the file to open it, it just does nothing.
In the system log I can see the message: 5470-5470/com.android.packageinstaller E/InstallStart: Requesting uid 10106 needs to declare permission android.permission.REQUEST_INSTALL_PACKAGES

Describe the solution you'd like
Add the permission android.permission.REQUEST_INSTALL_PACKAGES to manifest. If you want, I could create a pull request for that. Tested this already, it would work. No more work is needed.

Describe alternatives you've considered
Don't know any alternatives as the permission is required since Android 7.1.

Additional context
The screenshot shows the package installer asking the user to grant the permission. (after adding the permission to manifest):

Screenshot_1605205738
@RocketJannis RocketJannis added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 12, 2020
@bmarty bmarty self-assigned this Apr 28, 2021
bmarty added a commit that referenced this issue Apr 28, 2021
@bmarty
Add ability to install APK from directly from Element (#2381)
c40476a 
And cleanup `data class OpenFile`
@bmarty bmarty mentioned this issue Apr 28, 2021
Merged
@bmarty
Copy link
Member

bmarty commented Apr 28, 2021

Implemented in Element 1.1.7

yostyle referenced this issue in tchapgouv/tchap-android Apr 29, 2021
@yostyle
Merge vector-im/element-android 751efb5 into develop (#50)
0d177f0 
Changes in Element 1.1.7 (2021-XX-XX)
===================================================

Features ✨:
 - Spaces beta

Improvements 🙌:
 - Add ability to install APK from directly from Element (#2381)

Bugfix 🐛:
 - Message states cosmetic changes (#3007)
 - Fix exception in rxSingle (#3180)
 - Do not invite the current user when creating a room (#3123)
 - Fix color issues when the system theme is changed (#2738)
 - Fix issues on Android 11 (#3067)
 - Fix issue when opening encrypted files (#3186)

Translations 🗣:
 -

SDK API changes ⚠️:
 - RegistrationWizard.createAccount() parameters are now all optional, following Matrix spec (#3205)

Build 🧱:
 - Upgrade to gradle 7

Test:
 -

Other changes:
 - New store descriptions

Changes in Element 1.1.6 (2021-04-16)
===================================================

Bugfix 🐛:
 - Fix crash on the timeline
 - App crashes on "troubleshoot notifications" button (#3187)

Changes in Element 1.1.5 (2021-04-15)
===================================================

Bugfix 🐛:
 - Fix crash during Realm migration
 - Fix crash when playing video (#3179)
@bmarty bmarty mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-File-Download T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Android 11 fixes and other fixes for attachement element-hq/element-android
2 participants
@bmarty @RocketJannis