Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canceled messages sent after reconnection #2438

Closed
T-bond opened this issue Nov 23, 2020 · 1 comment · Fixed by #2468
Closed

Canceled messages sent after reconnection #2438

T-bond opened this issue Nov 23, 2020 · 1 comment · Fixed by #2468
Assignees
@bmarty
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 17

Comments

@T-bond
Copy link

T-bond commented Nov 23, 2020

Describe the bug
When I send a message without connection to the home server, and I cancel the sending of the message, it gets delivered after connection to the homeserver established.

To Reproduce
Steps to reproduce the behavior:

  1. Disconnect from your homeserver (e.g. killing your connections)
  2. Send a message (tested on encrypted DM, and encrypted room with only me in it)
  3. Cancel the sending of the message.
  4. Restore your connection to the homeserver.
  5. Wait, a little while. The message should appear, and the other party (if any) will get the message.

Expected behavior
The message not getting delivered.

Screenshots
https://youtu.be/M1Xc2cRbpVg

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S10+
  • OS: Android 10 (OneUI 2.5)

Additional context

  • App version and store: 1.0.10 [40100100] (F-bba167d4)
  • Homeserver: Custom, using Synapse 1.23

Add any other context about the problem here.
@bmarty
Copy link
Member

bmarty commented Nov 25, 2020

I can confirm the bug by reproducing it :/

@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems p1 labels Nov 25, 2020
@bmarty bmarty added this to the Sprint 17 milestone Nov 25, 2020
@bmarty bmarty self-assigned this Nov 27, 2020
bmarty added a commit that referenced this issue Nov 30, 2020
@bmarty
Fix cancellation of sending event (#2438)
cd983de
@bmarty bmarty mentioned this issue Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 17
Development

Successfully merging a pull request may close this issue.

Fix cancellation of event sending not always working element-hq/element-android
2 participants
@T-bond @bmarty