Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible or almost-invisible text with system theme #2738

Closed
lnicola opened this issue Jan 30, 2021 · 5 comments · Fixed by #3208
Closed

Invisible or almost-invisible text with system theme #2738

lnicola opened this issue Jan 30, 2021 · 5 comments · Fixed by #3208
Assignees
@bmarty

Comments

@lnicola
Copy link

lnicola commented Jan 30, 2021 •
edited

Describe the bug
I use the system theme and an app to automatically switch it (Auto Dark Theme). After a system theme switch, the text in Element is invisible, but toggling the Element theme between system and dark/light and back fixes it. I think Element doesn't notice that the text foreground color has changed.

I also noticed this with the bottom notification in the final step of the cross-signing flow. There's a "Finish >" step at the end and if you go back (cancel), the new session will remain inconsistent.

Screenshots

White on white text:
image

Gray on gray text:
image

Smartphone (please complete the following information):

  • Device: OnePlus 6T
  • OS: Android 10

Additional context

  • App version and store: 1.0.14 - Play Store
  • Homeserver: N/A
@pandalec
Copy link

I have the same problem. Need to close the application every day twice (day to night, night to day) :(

@lnicola
Copy link
Author

lnicola commented Feb 28, 2021

@parsifallo wait, does closing the app actually fix it for you?

@pandalec
Copy link

Sure. If light/dark mode switched, I swipe to close in Android to close the application. After opening Element again, the font color ist correct

@lnicola
Copy link
Author

lnicola commented Feb 28, 2021 •
edited

Ah, that's great. I'm sure I tried it, but I think my phone only closes the apps if I wait a couple of seconds before restarting them and I didn't wait enough.

@bmarty bmarty mentioned this issue Apr 20, 2021
Closed
@bmarty bmarty self-assigned this Apr 20, 2021
bmarty added a commit that referenced this issue Apr 20, 2021
@bmarty
Fix color issues when the system theme is changed (#2738)
ef1ed28
@bmarty bmarty mentioned this issue Apr 20, 2021
Merged
bmarty added a commit that referenced this issue Apr 20, 2021
@bmarty
Merge pull request #3208 from vector-im/feature/bma/fix_theme_switch
215166a 
Fix color issues when the system theme is changed (#2738)
@bmarty
Copy link
Member

bmarty commented Apr 26, 2021

Fixed in next release 1.1.7

yostyle referenced this issue in tchapgouv/tchap-android Apr 29, 2021
@yostyle
Merge vector-im/element-android 751efb5 into develop (#50)
0d177f0 
Changes in Element 1.1.7 (2021-XX-XX)
===================================================

Features ✨:
 - Spaces beta

Improvements 🙌:
 - Add ability to install APK from directly from Element (#2381)

Bugfix 🐛:
 - Message states cosmetic changes (#3007)
 - Fix exception in rxSingle (#3180)
 - Do not invite the current user when creating a room (#3123)
 - Fix color issues when the system theme is changed (#2738)
 - Fix issues on Android 11 (#3067)
 - Fix issue when opening encrypted files (#3186)

Translations 🗣:
 -

SDK API changes ⚠️:
 - RegistrationWizard.createAccount() parameters are now all optional, following Matrix spec (#3205)

Build 🧱:
 - Upgrade to gradle 7

Test:
 -

Other changes:
 - New store descriptions

Changes in Element 1.1.6 (2021-04-16)
===================================================

Bugfix 🐛:
 - Fix crash on the timeline
 - App crashes on "troubleshoot notifications" button (#3187)

Changes in Element 1.1.5 (2021-04-15)
===================================================

Bugfix 🐛:
 - Fix crash during Realm migration
 - Fix crash when playing video (#3179)
@bmarty bmarty mentioned this issue May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix color issues when the system theme is changed (#2738) element-hq/element-android
3 participants
@lnicola @bmarty @pandalec