Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isPublic field to RoomSummary #3292

Closed
elghrabi opened this issue May 6, 2021 · 2 comments
Closed

Add isPublic field to RoomSummary #3292

elghrabi opened this issue May 6, 2021 · 2 comments
Assignees
@bmarty
Labels
Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-parity-with-web

Comments

@elghrabi
Copy link

elghrabi commented May 6, 2021 •
edited by bmarty

Field needs to be added in RoomSummary so we can know if a room is public or not

EDIT

We will take the opportunity to display this information in the timeline, as per Element Web:

image

The picto "world" is displayed if and and only if the join rule is equal to "public". Ref: https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/avatars/DecoratedRoomAvatar.tsx#L93-L97
@elghrabi elghrabi added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label May 6, 2021
@bmarty
Copy link
Member

bmarty commented May 6, 2021

We will add a field

val joinRules: RoomJoinRules

to the room summary.

For reference: https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/state/StateServiceExtension.kt#L28

@yostyle yostyle mentioned this issue May 6, 2021
Merged
bmarty added a commit that referenced this issue May 7, 2021
@bmarty
Add the public icon on the rooms in the room list (#3292)
87b12b7
@bmarty
Copy link
Member

bmarty commented May 10, 2021

Implemented in Element Android and it's SDK 1.1.7

@bmarty bmarty closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-parity-with-web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmarty @elghrabi