Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission rework #3667

Merged
merged 9 commits into from
Jul 13, 2021
Merged

Permission rework #3667

merged 9 commits into from
Jul 13, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 12, 2021

Especially better handling of the "denied forever" permission user story.

Add a new debug screen to play with permission request from the application.

so now when requesting permissions:

  • already granted: sync call (no change on this part)
  • not yet granted:
    • user give permission: async success
    • user denies: no more thing to do, the action is not performed
    • user denies and check do not ask again: no more thing to do, the action is not performed
  • not yet granted, user has previously checked do not ask again:
    • a dialog or a snackbar is displayed to ask the user to open the system settings to grant the permission
permissions.mp4

@bmarty bmarty requested a review from BillCarsonFr July 12, 2021 22:25
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillCarsonFr BillCarsonFr self-requested a review July 13, 2021 08:00
@bmarty bmarty merged commit c08bd66 into develop Jul 13, 2021
@bmarty bmarty deleted the feature/bma/permission branch July 13, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants