Feature/fga/log tags voip #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Jul 23, 2021
| object VOIP : LoggerTag("VOIP", null) | ||
|
|
||
| val value: String | ||
| get() { |
There was a problem hiding this comment.
Affect instead of get() to avoid computation each time it's called?
| @@ -180,12 +183,18 @@ internal class CallSignalingHandler @Inject constructor(private val activeCallHa | |||
| if (event.roomId == null || event.senderId == null) { | |||
| return | |||
| } | |||
| val now = System.currentTimeMillis() | |||
| val age = now - (event.ageLocalTs ?: now) | |||
| if (age > 40_000 && event.getClearType() == EventType.CALL_INVITE) { | |||
| import timber.log.Timber | ||
| import java.util.HashSet | ||
|
|
||
| private val loggerTag = LoggerTag("API21AudioDeviceDetector", LoggerTag.VOIP) |
There was a problem hiding this comment.
Why not using API21AudioDeviceDetector::class.simpleName instead of hard coded string? For proguard?
bmarty
reviewed
Jul 23, 2021
| @@ -22,16 +22,13 @@ package org.matrix.android.sdk.api.logger | |||
| * val loggerTag = LoggerTag("MyTag", LoggerTag.VOIP) | |||
| * Timber.tag(loggerTag.value).v("My log message") | |||
| */ | |||
| open class LoggerTag(private val _value: String, private val parentTag: LoggerTag? = null) { | |||
| open class LoggerTag(_value: String, parentTag: LoggerTag? = null) { | |||
|
|
|||
| object VOIP : LoggerTag("VOIP", null) | |||
There was a problem hiding this comment.
, null could be ommited but I can live with that :)
bmarty
reviewed
Jul 23, 2021
| @@ -185,7 +186,7 @@ internal class CallSignalingHandler @Inject constructor(private val activeCallHa | |||
| } | |||
| val now = System.currentTimeMillis() | |||
| val age = now - (event.ageLocalTs ?: now) | |||
| if (age > 40_000 && event.getClearType() == EventType.CALL_INVITE) { | |||
| if (age > MAX_AGE_TO_RING) { | |||
There was a problem hiding this comment.
not checking the type anymore? EDIT: I guess it's doen before, else we should not be in this fun, sorry
bmarty
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some Parent class to add handler logger tags more properly.
Start branching that for Voip logs/
Also make end call notification disappear quickly if possible.