Fix attachment menu animation order

[pr0gr8mm3r]

Pull Request Checklist

• Changes has been tested on an Android device or Android emulator with API 21

Tested on device with Android 11, shouldn't matter (assuming it worked before 😉)

• UI change has been tested on both light and dark themes
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off

What it does

This PR changes the order in which the items in the attachement menu appear. Currently, the ones on the right are faster than the ones on the left. Because the '+'-Button to trigger the menu is on the left, this doesn't make sense.

This behavior is more noticable if animations are disabled, because the menu doesn't have the circular mask animation. That's why the videos are recorded with animations disabled.

Current animation

MP4_20210805_110437.mp4

New animation

recording_20210818_214043_Trim.mp4

[bmarty]

Thanks for the PR, you are right, the animation are better like this.

Previously the plus button was on the right and has been recently moved to the left.

As a small remark users with RTL languages does not have the bug at the moment, but after this PR will be merged they will see the bug. But this problem is not introduced by your PR.

[bmarty]

My bad in RTL, the icons are also mirrored, so it will be fine.