New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle long click on room in the room list #395
Comments
Is it not possible currently to leave a room in RiotX? I couldn't find that. |
No, not yet |
Hey @bmarty, I've been looking at this in closer detail, and think the best thing to do would be to implement:
So I've prepared icons for these here: I'm apprehensive to spend development time implementing Favourite, Low Priority or Direct Chat as they'll change in the not-far future as we work on Communities & Immutable DM's. Do you agree? Or would you prefer to implement them now for legacy parity, even if they turn out to be short lived? |
Thanks @nadonomy for the design, Ok to postpone "Favourite, Low Priority or Direct Chat" |
"Also in Riot Android, we have an option to add the room to the mobile Home, as a shortcut". Why not show favorited rooms in Home, instead of having a separate option for that? |
That would be really convenient! I'd hope it ends up being just like that. |
@nadonomy it's maybe a good idea to add a header to the bottom sheet with room avatar and name, as we do for bottom sheet of messages, what do you think? |
Yeah that sounds good, to re-enforce the context. |
@ganfra I've uploaded the artboard to Zeplin here, and also added a green check mark to show which notification setting is active: I looked into adding an empty SVG node to standardise the size but then SVGO was stripping it on export. If the icon sizes are still problematic to work with when exporting from Zeplin let me know and we can figure something out. |
To display a bottom sheet, as we do on long click on message with possible action for the room.
It could be interesting to add an item at the bottom of a non empty room list to inform the user that there is action behind a long click. Suggested wording: "Long click on a room to see more options". This item could be hidden after the user has done the gesture once.
Currently in RiotWeb, we have:
Also in Riot Android, we have an option to add the room to the mobile Home, as a shortcut.
The text was updated successfully, but these errors were encountered: