Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle long click on room in the room list #395

Closed
bmarty opened this issue Jul 18, 2019 · 9 comments
Closed

Handle long click on room in the room list #395

bmarty opened this issue Jul 18, 2019 · 9 comments
Assignees
Milestone

Comments

@bmarty
Copy link
Member

bmarty commented Jul 18, 2019

To display a bottom sheet, as we do on long click on message with possible action for the room.

It could be interesting to add an item at the bottom of a non empty room list to inform the user that there is action behind a long click. Suggested wording: "Long click on a room to see more options". This item could be hidden after the user has done the gesture once.

Currently in RiotWeb, we have:
image

Also in Riot Android, we have an option to add the room to the mobile Home, as a shortcut.

@bmarty bmarty added legacy-feature X-Needs-Design May require input from the design team labels Jul 18, 2019
@rkfg
Copy link
Contributor

rkfg commented Jul 19, 2019

Is it not possible currently to leave a room in RiotX? I couldn't find that.

@bmarty
Copy link
Member Author

bmarty commented Jul 19, 2019

No, not yet

@nadonomy
Copy link
Member

nadonomy commented Aug 7, 2019

Hey @bmarty, I've been looking at this in closer detail, and think the best thing to do would be to implement:

  • Notification settings (Noisy / All / Mentions / Mute)
  • Leave
  • Settings

Comp

So I've prepared icons for these here:

riot-x-long-press.zip

I'm apprehensive to spend development time implementing Favourite, Low Priority or Direct Chat as they'll change in the not-far future as we work on Communities & Immutable DM's. Do you agree? Or would you prefer to implement them now for legacy parity, even if they turn out to be short lived?

@nadonomy nadonomy removed the X-Needs-Design May require input from the design team label Aug 7, 2019
@bmarty bmarty added this to the sprint4 milestone Aug 20, 2019
@bmarty
Copy link
Member Author

bmarty commented Aug 20, 2019

Thanks @nadonomy for the design, Ok to postpone "Favourite, Low Priority or Direct Chat"

@frandavid100
Copy link

"Also in Riot Android, we have an option to add the room to the mobile Home, as a shortcut".

Why not show favorited rooms in Home, instead of having a separate option for that?

@andycuccaro
Copy link

Why not show favorited rooms in Home, instead of having a separate option for that?

That would be really convenient! I'd hope it ends up being just like that.

@bmarty
Copy link
Member Author

bmarty commented Oct 23, 2019

@nadonomy it's maybe a good idea to add a header to the bottom sheet with room avatar and name, as we do for bottom sheet of messages, what do you think?

@nadonomy
Copy link
Member

Yeah that sounds good, to re-enforce the context.

@ganfra ganfra self-assigned this Oct 23, 2019
@nadonomy
Copy link
Member

@ganfra I've uploaded the artboard to Zeplin here, and also added a green check mark to show which notification setting is active:

https://zpl.io/a3dOWx1

I looked into adding an empty SVG node to standardise the size but then SVGO was stripping it on export. If the icon sizes are still problematic to work with when exporting from Zeplin let me know and we can figure something out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants