-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url preview #481
Comments
I would like to work on this issue |
Ok, thanks |
@KaenDagger did you get far? |
Most self hosted users wouldn't mind if URL is leaked to HS. Maybe let the users decide by providing an option to enable URL previews in encrypted rooms as well? |
It'd be nice to have a toggle for default preference for encrypted rooms. |
is minivector from f-droid currently the only android client with url previews? |
@niquewoodhouse prepped a simple proposal for visualising URL previews here: https://www.figma.com/file/tnv1s5KUVK38Byt54gs7GM/Timeline-URL-previews?node-id=8%3A122 |
@bmarty what is this view? it is timeline? |
@bmarty Has the current timeline function been released? Where to click in |
Doesn't work for me. |
Available in Element Android 1.0.12 and up |
Yep, 1.0.12 is installed. |
@532910 could you open a dedicated issue to track your problem please? Thanks |
Display URL preview in the timeline, as other Riot clients does (except - sadly - Riot iOS)
Do not perform URL previewing in e2e rooms, as it leaks the URL to the HS
EDIT: Update of description:
We need design on how to display URL previews in the timeline.
We have several states to consider: loading/error/loaded. It should be good to avoid blink in the timeline, so all the states should take the same space.
Several preview can be displayed in a row if the message contains several URLs.
Also it is possible to close the preview. On Riot-Android, it had the effect of storing the url value, to avoid display the url preview anymore for that URL. On Element Web it seems that this is not the current behavior, it just closes the preview.
The current data we get for a preview:
As suggested by @dhrunia, we could consider displaying URL preview in e2e room, but the decision has to be taken globally for the Element product.
Ref: https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-media-r0-preview-url
Element URL display (FTR):
Edit:
Design is ready: https://www.figma.com/file/tnv1s5KUVK38Byt54gs7GM/Timeline-URL-previews?node-id=0%3A1 , proposal 2 is mature (we think :) but feedback welcome via Figma comments
The text was updated successfully, but these errors were encountered: