Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url preview #481

Closed
bmarty opened this issue Aug 13, 2019 · 13 comments · Fixed by #2490
Closed

Url preview #481

bmarty opened this issue Aug 13, 2019 · 13 comments · Fixed by #2490
Assignees
Labels
X-Needs-Design May require input from the design team Z-parity-with-web
Milestone

Comments

@bmarty
Copy link
Member

bmarty commented Aug 13, 2019

Display URL preview in the timeline, as other Riot clients does (except - sadly - Riot iOS)

Do not perform URL previewing in e2e rooms, as it leaks the URL to the HS

EDIT: Update of description:

We need design on how to display URL previews in the timeline.
We have several states to consider: loading/error/loaded. It should be good to avoid blink in the timeline, so all the states should take the same space.
Several preview can be displayed in a row if the message contains several URLs.
Also it is possible to close the preview. On Riot-Android, it had the effect of storing the url value, to avoid display the url preview anymore for that URL. On Element Web it seems that this is not the current behavior, it just closes the preview.

The current data we get for a preview:

  • The url itself
  • An image URI (optional)
  • A title
  • A short description

As suggested by @dhrunia, we could consider displaying URL preview in e2e room, but the decision has to be taken globally for the Element product.

Ref: https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-media-r0-preview-url

Element URL display (FTR):

image

Edit:
Design is ready: https://www.figma.com/file/tnv1s5KUVK38Byt54gs7GM/Timeline-URL-previews?node-id=0%3A1 , proposal 2 is mature (we think :) but feedback welcome via Figma comments

@bmarty bmarty added legacy-feature X-Needs-Design May require input from the design team labels Aug 13, 2019
@RotBolt
Copy link

RotBolt commented Aug 19, 2019

I would like to work on this issue

@bmarty
Copy link
Member Author

bmarty commented Aug 20, 2019

Ok, thanks

@ptman
Copy link

ptman commented Feb 26, 2020

@KaenDagger did you get far?

@dhrunia
Copy link

dhrunia commented Jun 20, 2020

Do not perform URL previewing in e2e rooms, as it leaks the URL to the HS

Most self hosted users wouldn't mind if URL is leaked to HS. Maybe let the users decide by providing an option to enable URL previews in encrypted rooms as well?

@532910
Copy link
Contributor

532910 commented Jun 20, 2020

It'd be nice to have a toggle for default preference for encrypted rooms.

@ptman
Copy link

ptman commented Aug 6, 2020

is minivector from f-droid currently the only android client with url previews?

@bmarty bmarty moved this from Backlog to 🎨 Waiting for design in Deprecated - Element Android Dashboard Aug 17, 2020
@nadonomy
Copy link

@niquewoodhouse prepped a simple proposal for visualising URL previews here: https://www.figma.com/file/tnv1s5KUVK38Byt54gs7GM/Timeline-URL-previews?node-id=8%3A122

@bmarty bmarty modified the milestones: Phase 2, Sprint 17 Nov 6, 2020
@bmarty bmarty mentioned this issue Dec 4, 2020
2 tasks
@Alvazz
Copy link

Alvazz commented Dec 7, 2020

@bmarty what is this view? it is timeline?

@Alvazz
Copy link

Alvazz commented Dec 7, 2020

@bmarty Has the current timeline function been released? Where to click in

@532910
Copy link
Contributor

532910 commented Dec 19, 2020

Doesn't work for me.
Inline URL preview is enabled in Preferences, element-web has enabled URL previews for this room and it shows previews.

@bmarty
Copy link
Member Author

bmarty commented Dec 19, 2020

Available in Element Android 1.0.12 and up

@532910
Copy link
Contributor

532910 commented Dec 19, 2020

Yep, 1.0.12 is installed.

@bmarty
Copy link
Member Author

bmarty commented Dec 19, 2020

@532910 could you open a dedicated issue to track your problem please? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Design May require input from the design team Z-parity-with-web
Projects
No open projects
Deprecated - Element Android Dashboard
  
🎨 Waiting for design
Development

Successfully merging a pull request may close this issue.

7 participants