Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App crashes on attempt to log in to SAML-only homeserver #4969

Closed
AndrewFerr opened this issue Jan 18, 2022 · 4 comments
Closed

App crashes on attempt to log in to SAML-only homeserver #4969

AndrewFerr opened this issue Jan 18, 2022 · 4 comments
Assignees
@ouchadam
Labels
A-SSO O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash Z-FTUE Issue is relevant to the first time use project or experience
Projects
Issue triage Android App Team

Comments

@AndrewFerr
Copy link
Member

Steps to reproduce

  1. Log out
  2. On the start screen, tap "I already have an account"
  3. Tap "Other"
  4. In the "Address" field, type the address of a homeserver that supports only SAML/SSO logins, such as https://chat.mozilla.org

Outcome

What did you expect?

The app should prompt to continue with a SAML/SSO login.

What happened instead?

The app crashes.

Your phone model

Samsung Galaxy S8

Operating system version

Android 9

Application version and app store

1.3.16-dev

Homeserver

chat.mozilla.org

Will you send logs?

Yes
@AndrewFerr AndrewFerr added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 18, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Jan 18, 2022
@bmarty bmarty mentioned this issue Jan 18, 2022
Closed
37 tasks
@bmarty
Copy link
Member

bmarty commented Jan 18, 2022

Crash confirmed.
It's working correctly when reverting to the legacy auth flow.

TODO:

  • Check that this issue also impact 1.3.14 - If this is not the case, no need to include the fix in [Release] Element Android v1.3.15 - Corrective release #4970
  • Make the flow Get Started / mozilla server / SSO page work. No we see a dialog: "the server does not accept new accounts".
  • Make the flow I already have an account / mozilla server / SSO page work (it is not working on legacy, but works on login2). This is P2 regarding the crash fix
  • Add the 2 flows above to the all screen sanity test.

@ouchadam ouchadam self-assigned this Jan 18, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Jan 18, 2022
@ouchadam ouchadam added this to In progress in Android App Team Jan 18, 2022
@ouchadam ouchadam added A-SSO Z-Crash Z-FTUE Issue is relevant to the first time use project or experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 18, 2022
@ouchadam
Copy link
Contributor

it's working in the legacy onboarding flow

GIF
before-ftue-sso

@ouchadam ouchadam mentioned this issue Jan 18, 2022
Merged
@ouchadam
Copy link
Contributor

ouchadam commented Jan 18, 2022 •
edited

Confirmed, the crash was introduced (by enabling the feature) in 1.3.13 by #4872

  • Make the flow Get Started / mozilla server / SSO page work. No we see a dialog: "the server does not accept new accounts".
  • Make the flow I already have an account / mozilla server / SSO page work (it is not working on legacy, but works on login2). This is P2 regarding the crash fix

Both cases are fixed by #4973

  • Add the 2 flows above to the all screen sanity test.

#4975

@ouchadam
Copy link
Contributor

Fixed in 1.3.15

Issue triage automation moved this from Triaged to Closed Jan 18, 2022
Android App Team automation moved this from In progress to Merged Jan 18, 2022
@daniellekirkwood daniellekirkwood added Z-FTUE Issue is relevant to the first time use project or experience and removed Z-FTUE Issue is relevant to the first time use project or experience labels Feb 7, 2022
@RiotRobot RiotRobot moved this from Closed to Triaged in Issue triage Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
A-SSO O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash Z-FTUE Issue is relevant to the first time use project or experience
Projects
Android App Team
Merged
Issue triage
Triaged
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ouchadam @AndrewFerr @bmarty @daniellekirkwood