Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timber logging in release builds #519

Closed
PavelSynek opened this issue Aug 23, 2019 · 1 comment · Fixed by #527
Closed

Timber logging in release builds #519

PavelSynek opened this issue Aug 23, 2019 · 1 comment · Fixed by #527
Assignees
@bmarty
Milestone
sprint3

Comments

@PavelSynek
Copy link

PavelSynek commented Aug 23, 2019 •
edited

RiotX logs all Timber messages in release build, including message payloads.

Would you be open to PR which plants Timber.DebugTree only for debug builds?
@PavelSynek PavelSynek changed the title Timber logging in production Timber logging in release builds Aug 23, 2019
@bmarty bmarty added p1 labels Aug 23, 2019
@bmarty bmarty added this to the sprint3 milestone Aug 23, 2019
@bmarty
Copy link
Member

bmarty commented Aug 23, 2019

We need the log for the Rageshake feature (log can be sent by user to help debug issue). But there is absolutely no reason to log message content, thanks for the good catch.
I add the issue to bucket.

@bmarty bmarty self-assigned this Aug 29, 2019
bmarty added a commit that referenced this issue Aug 29, 2019
@bmarty
Privacy: remove log of notifiable event (#519)
ce55701
@bmarty bmarty mentioned this issue Aug 29, 2019
Merged
6 tasks
bmarty added a commit that referenced this issue Aug 29, 2019
@bmarty
Merge pull request #527 from vector-im/feature/privacy
95c4c9c 
Privacy: remove log of notifiable event (#519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
None yet
Projects
None yet
Milestone
sprint3
Development

Successfully merging a pull request may close this issue.

Privacy: remove log of notifiable event (#519) element-hq/element-android
2 participants
@bmarty @PavelSynek