Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting showing which Space is selected #5346

Closed
1 of 2 tasks
Tracked by #164
kittykat opened this issue Feb 24, 2022 · 2 comments · Fixed by #5436
Closed
1 of 2 tasks
Tracked by #164

Fix highlighting showing which Space is selected #5346

kittykat opened this issue Feb 24, 2022 · 2 comments · Fixed by #5436
Assignees
@fedrunov
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-IA Issue is related to information architecture Z-Labs
Projects
Issue triage

Comments

@kittykat
Copy link
Contributor

kittykat commented Feb 24, 2022 •
edited

On Android, the current Space is only highlighted with a green bar. Nique says that the designs show it as having a background highlighting as well.

This is done correctly on iOS.

Tasks
@kittykat kittykat mentioned this issue Feb 24, 2022
Closed
20 tasks
@kittykat kittykat changed the title Selected space highlighting in the left menu Fix highlighting showing which Space is selected Feb 24, 2022
@kittykat kittykat transferred this issue from element-hq/element-meta Feb 24, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Feb 24, 2022
@kittykat kittykat added A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-IA Issue is related to information architecture Team: Delight labels Feb 24, 2022
@niquewoodhouse
Copy link

Here's the original design light, dark

Issue triage automation moved this from Incoming to Closed Feb 25, 2022
@fedrunov fedrunov mentioned this issue Mar 7, 2022
Merged
@bmarty
Copy link
Member

bmarty commented Mar 10, 2022

In EA 1.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedrunov fedrunov

Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-IA Issue is related to information architecture Z-Labs
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change selected space highlight element-hq/element-android
4 participants
@kittykat @niquewoodhouse @bmarty @fedrunov