Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rooms list] Do not suggest collapse the unique section #5347

Open
giomfo opened this issue Feb 24, 2022 · 10 comments
Open

[Rooms list] Do not suggest collapse the unique section #5347

giomfo opened this issue Feb 24, 2022 · 10 comments
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Feb 24, 2022

Your use case

What would you like to do?

In the rooms list, the sections are collapsable
image

This is ok when there are severals section, but irrelevant when there is only one section.
I suggest here disabling and hiding the option when there is only one section (this is the case for example when I don't have pending invites and when I didn't taf room (favorite/low priority))
When we select a space the case where there is only one section is more frequent

Have you considered any alternatives?

No response

Additional context

No response

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 24, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Feb 24, 2022
@giomfo
Copy link
Member Author

giomfo commented Feb 24, 2022

We can prepare a PR if you agree with the suggestion

@ouchadam ouchadam added X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team labels Feb 28, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Feb 28, 2022
@daniellekirkwood
Copy link
Contributor

Hi @giomfo

Please raise the PR.

If there is only one section, then that section should not be collapsible. We recently made this same decision and change on iOS too.

Thanks

@bmarty
Copy link
Member

bmarty commented Mar 23, 2022

I do not like the idea behind this issue TBH. It should still be collapsible, just for the fact that user can quickly see what's below (= nothing) without having to scroll to the bottom.

@ganfra
Copy link
Contributor

ganfra commented Mar 23, 2022

Also the PR #5580 had issues, so reverted for now.

@giomfo
Copy link
Member Author

giomfo commented Mar 23, 2022

I do not like the idea behind this issue TBH. It should still be collapsible, just for the fact that user can quickly see what's below (= nothing) without having to scroll to the bottom.

@bmarty The fact that the section is not collapsible should provide this information (-> no more section below)

Also the PR #5580 had issues, so reverted for now.

@ganfra can you please tell more about the issues? Eventually in the PR #5580 itself

@bmarty
Copy link
Member

bmarty commented Mar 23, 2022

OK, so, we will have to ensure that this is working:

  • an invite is there, so the sections can be collaped
  • the user collapse the "rooms" section
  • the invite is gone (either by accepting or rejecting it)

-> make sure that the "rooms" section is expanded, or expandable again

@bmarty
Copy link
Member

bmarty commented Mar 23, 2022

(this is not the issue we have seen though)

The issues was:

  • even if the arrow is hidden, the header is still clickable and the list collapse
  • sometimes the arrows are not displayed, even if there are several sections

All the fixes are in #5616 from @Florian14 , but we decided to revert the original PR also to discuss a bit more about this "feature"

@Florian14
Copy link
Contributor

OK, so, we will have to ensure that this is working:

* an invite is there, so the sections can be collaped

* the user collapse the "rooms" section

* the invite is gone (either by accepting or rejecting it)

-> make sure that the "rooms" section is expanded, or expandable again

I don't think so this case was handled before but it should be fine with #5616: a section is expanded according to a flag value or if there is no other section

@bmarty
Copy link
Member

bmarty commented Mar 23, 2022

There is also another pb (which is maybe not new)

  • on "Direct Message" tab collapse a section
  • go to "Rooms" tab
  • go back to "Direct Message" tab

-> The section is expanded, but the state is not updated, it means that the user has to click twice on the section header to collapse it.

@giomfo
Copy link
Member Author

giomfo commented Mar 25, 2022

@Florian14 can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Development

No branches or pull requests

7 participants