Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when closing room during timeline decryption #5552

Merged

Conversation

SpiritCroc
Copy link
Contributor

Signed-off-by: Tobias Büttner dev@spiritcroc.de

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Catch the InterrutedException produced by runBlocking

Motivation and context

When shutting down the executor, the app crashes if we don't catch that exception for an ongoing runBlocking.

Tests

Open the room and close it again.
Can insert a Thread.sleep(1000) into the runBlocking to ensure it is still running.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr self-requested a review March 18, 2022 10:22
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thx

@BillCarsonFr BillCarsonFr merged commit 189683a into element-hq:develop Mar 18, 2022
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants