Direct login tests #5628
Merged
Direct login tests #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
commented
Mar 24, 2022
| { copy(isLoading = true) }, | ||
| { copy(isLoading = false) } | ||
| ) | ||
| .assertEvents(OnboardingViewEvents.OnAccountSignedIn) |
There was a problem hiding this comment.
this test fails when the fix from #5623 is missing
ouchadam
force-pushed
the
feature/adm/direct-login-tests
branch
from
c9d2ed7
to
56f2aed
Compare
…model test case - will ensure we emit account sign in when going via direct login flow
ouchadam
force-pushed
the
feature/adm/direct-login-tests
branch
from
56f2aed
to
776cf24
Compare
ouchadam
requested review from
a team and
ganfra
and removed request for
a team
ganfra
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Adds unit tests around the direct login flow via the
OnboardingViewModeland the happy paths of the extractedDirectLoginUseCaseMotivation and context
To ensure the direct login flow is treated as a sign in and avoid regressions such as #5623
Screenshots / GIFs
Tests
Tested devices