Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore user must perform an initial sync #5767

Merged
merged 11 commits into from
Apr 14, 2022
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 14, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Displaying a confirmation dialog when a user is unignored, and perform an init sync when it's done:

  • from the main setting screen
  • from the room member list
  • from the slash command action

Motivation and context

Closes #3439

Screenshots / GIFs

From room member list From settings From slash command
unignore unignore2 unignore3

Tests

  • Ignore a user
  • Unignore a user -> observe the initial sync

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@github-actions
Copy link

github-actions bot commented Apr 14, 2022

Unit Test Results

114 files  ±0  114 suites  ±0   1m 21s ⏱️ -9s
201 tests ±0  201 ✔️ ±0  0 💤 ±0  0 ±0 
674 runs  ±0  674 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b1cff1a. ± Comparison against base commit 9b7e94e.

♻️ This comment has been updated with latest results.

@bmarty bmarty requested review from a team and ariskotsomitopoulos and removed request for a team April 14, 2022 14:48
@@ -634,7 +634,7 @@
<string name="room_participants_action_ignore">Ignore</string>

<string name="room_participants_action_unignore_title">Unignore user</string>
<string name="room_participants_action_unignore_prompt_msg">Unignoring this user will show all messages from them again.</string>
<string name="room_participants_action_unignore_prompt_msg">Unignoring this user will show all messages from them again.\n\nNote that this action will restart the app and it may take some time.</string>
Copy link
Member Author

@bmarty bmarty Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is OK not to create a new string. The translations will be updated one by one, but the use case is not performed a lot.

@bmarty bmarty marked this pull request as ready for review April 14, 2022 14:58
@bmarty bmarty requested a review from giomfo April 14, 2022 14:59
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks fine. We need the Initial Sync in order to fetch already ignored messages? or there is another reason?

@bmarty
Copy link
Member Author

bmarty commented Apr 14, 2022

Thanks for your fast review!

The PR looks fine. We need the Initial Sync in order to fetch already ignored messages? or there is another reason?

Yes, the server does not send the message from ignored users to the client. So once the account data is updated, we have to perform a new complete sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unignoring a user tells you that it'll restart the app but doesn't
2 participants