Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different emoticons labels between Riot desktop and Riotx #671

Closed
DamienCassou opened this issue Nov 6, 2019 · 3 comments · Fixed by #673
Closed

Different emoticons labels between Riot desktop and Riotx #671

DamienCassou opened this issue Nov 6, 2019 · 3 comments · Fixed by #673
Assignees
Labels
Milestone

Comments

@DamienCassou
Copy link

This seems similar to #355 but this one has been closed and the problem persists in 0.8.0-dev (157295240, F-b1171, downloaded from f-droid repo by Krombel, riotx-dev-fdroid).

@bmarty
Copy link
Member

bmarty commented Nov 6, 2019

@bmarty bmarty added the I18n label Nov 6, 2019
@bmarty
Copy link
Member

bmarty commented Nov 6, 2019

After a quick investigation, the Android system may consider that default language is EN-US, as does Android Studio:
Default:
image
en-US:
image
So in our case, we should do the same i.e. put US string in the default resource directory and create a resource directory for en-GB...

@bmarty bmarty added this to the Sprint5 milestone Nov 6, 2019
bmarty added a commit that referenced this issue Nov 6, 2019
@bmarty bmarty mentioned this issue Nov 6, 2019
@DamienCassou
Copy link
Author

Is your local set to en-US?

I think it is because my language is set to "English (United States)"

@bmarty bmarty self-assigned this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants