Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date description should not depend on the time #822

Closed
fbruetting opened this issue Jan 8, 2020 · 3 comments · Fixed by #1803
Closed

Date description should not depend on the time #822

fbruetting opened this issue Jan 8, 2020 · 3 comments · Fixed by #1803

Comments

@fbruetting
Copy link

As you see below, the uppermost reader has read that message about 21 hours ago, which seems to be why RiotX displays that date as “the day before yesterday” (German: “vorgestern”). The others have read that message more than 24 hours ago (but on the same day), and there RiotX displays the timestamp via an exact date.

Would be nice if the threshold could be raised from “24 hours ago” to “24 hours ago + that whole day”, then the timestamps would be unified for every day.

Screenshot_20200108-191733
@bmarty
Copy link
Member

bmarty commented Jan 9, 2020 •
edited

I'm not sure to understand the problem. Could you precise the current date and time of the screenshot please?

@fbruetting
Copy link
Author

The screen shot is of the day before yesterday and all persons have read the message at the same day (which is why it would be good to unify the timestamp, because currently, it looks like the first person read the message on another day than everybody else).

@bmarty
Copy link
Member

bmarty commented Jan 12, 2020

Ok, so the screenshot has been taken the 8th of January at 19:17.

I see the pb now.
I'll see what we can do to improve this.

czeidler added a commit to czeidler/riotX-android that referenced this issue Jul 24, 2020
@czeidler
Fix relative date time formatting (element-hq#822)
b2365e6 
The transitionResolution parameter has to go back to the beginning of
the day. In general, going back 24h is not enough.
@czeidler czeidler mentioned this issue Jul 24, 2020
Merged
6 tasks
czeidler added a commit to czeidler/riotX-android that referenced this issue Aug 5, 2020
@czeidler
Fix relative date time formatting (element-hq#822)
5e711f6 
The transitionResolution parameter has to go back to the beginning of
the day. In general, going back 24h is not enough.
bmarty added a commit that referenced this issue Aug 11, 2020
@bmarty
Merge pull request #1803 from czeidler/relative-date-time-formatter
98aeee9 
Relative date time formatter #822
@bmarty bmarty mentioned this issue Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relative date time formatter #822 czeidler/riotX-android
2 participants
@bmarty @fbruetting