Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix-Ids are sometimes shown in notice events instead of display names #8365

Closed
giomfo opened this issue Apr 25, 2023 · 1 comment
Closed

Matrix-Ids are sometimes shown in notice events instead of display names #8365

giomfo opened this issue Apr 25, 2023 · 1 comment
Assignees
@yostyle
Labels
A-Display name O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Issue triage

Comments

@giomfo
Copy link
Member

giomfo commented Apr 25, 2023 •
edited

Steps to reproduce

I changed the display name of an existing user

Outcome

What did you expect?

the notice should be formatted like on the Web client
image

What happened instead?

The matrixId is shown in the notice
image

The request here is to change the profile notice on Element-Android by using the same format as Element-Web
(The profile notices are currently built by the method buildProfileNotice which uses the event.senderId for each display name changes).

During this task I would ask to check buildMembershipNotice too. Can you confirm the provided senderName isn't null as soon as the sender has an actual displayName. Some people complained to observe mxId in these notices, which means that the senderName was null for unexpected reasons.

Your phone model

No response

Operating system version

No response

Application version and app store

v1.5.28

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 25, 2023
@RiotRobot RiotRobot added this to Incoming in Issue triage Apr 25, 2023
@giomfo giomfo mentioned this issue Apr 25, 2023
Closed
@yostyle yostyle moved this from Incoming to Triaged in Issue triage Apr 27, 2023
@giomfo
Copy link
Member Author

giomfo commented May 3, 2023

@yostyle I got a new kind of notice to check during this task. Indeed in case of power level changes, Element-Android displays some notices with the matrix-id instead of the potential member display name:
image

@yostyle yostyle mentioned this issue May 4, 2023
Merged
15 tasks
@giomfo giomfo closed this as completed May 10, 2023
Issue triage automation moved this from Triaged to Closed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yostyle yostyle

Labels
A-Display name O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yostyle @giomfo