Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct details when a poll is ended. #8471

Merged
merged 1 commit into from Jun 9, 2023

Conversation

csmith
Copy link
Contributor

@csmith csmith commented May 26, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Previously, the "end poll" timeline item always showed the title and options from the start event, regardless of whether any edits had been made.

Now we show the latest edit, if available, falling back to the original otherwise.

Screenshots / GIFs

device-2023-05-26-114409.webm

Tests

  • Create a poll
  • Edit the poll
  • Vote (optional)
  • End the poll
  • Look at the created ended poll result event in the timeline

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

Previously, the "end poll" timeline item always showed the title
and options from the start event, regardless of whether any edits
had been made.

Now we show the latest edit, if available, falling back to the
original otherwise.
@csmith csmith force-pushed the bugfix/cjs/poll-finish-contents branch from 93b2086 to 37429c2 Compare May 26, 2023 11:07
@csmith csmith marked this pull request as ready for review May 26, 2023 11:07
@csmith csmith requested review from a team and ganfra and removed request for a team May 26, 2023 11:07
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 48df113 into develop Jun 9, 2023
19 of 21 checks passed
@bmarty bmarty deleted the bugfix/cjs/poll-finish-contents branch June 9, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants