Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bma/no jcenter #8556

Merged
merged 13 commits into from Jun 27, 2023
Merged

Feature/bma/no jcenter #8556

merged 13 commits into from Jun 27, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 23, 2023 •
edited

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes #2773 by importing source code into the project. This is a bit dirty but at least we do not rely on bintray anymore.

Motivation and context

Bintray artifacts not available anymore.

Screenshots / GIFs

Tests

  • QrCodeScannerFragment still working on emu.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty marked this pull request as ready for review June 23, 2023 21:26
@bmarty bmarty requested a review from BillCarsonFr June 23, 2023 21:26
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 20 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 265 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bmarty
Copy link
Member Author

bmarty commented Jun 26, 2023

doesNotProcessMarkdownBoldAndItalic test is failing, OK locally, run again on CI.

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jun 26, 2023
BillCarsonFr
BillCarsonFr approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 2b4b5f0 into develop Jun 27, 2023
16 of 19 checks passed
@bmarty bmarty deleted the feature/bma/noJcenter branch June 27, 2023 15:05
@yostyle yostyle mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JCenter is shutting down at May 1st 2021
2 participants
@bmarty @BillCarsonFr