Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward pagination: timeline scroll to the last event when paginating join the live chunk #862

Closed
bmarty opened this issue Jan 17, 2020 · 1 comment
Closed

Forward pagination: timeline scroll to the last event when paginating join the live chunk #862

bmarty opened this issue Jan 17, 2020 · 1 comment
Assignees
@ganfra
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint9

Comments

@bmarty
Copy link
Member

bmarty commented Jan 17, 2020

To reproduce:

  • jump to first unread message, or clicking to a permalink.
  • Scroll to the live
  • The SDK is forward paginating, new events are coming from the server
  • Well we reach the live chunk (i.e. the gap is filled), we observe that the list scroll to the bottom.

It can be super annoying if the live chunk was big.

The considered solution is to add a new SendState SYNCED_PAGINATION, to distinguish if the event comes from the sync (so is live and timeline should automatically scroll, or from pagination, so the timeline should not automatically scroll.
@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems feature:timeline labels Jan 17, 2020
@bmarty bmarty added this to the Sprint9 milestone Jan 17, 2020
@bmarty
Copy link
Member Author

bmarty commented Feb 5, 2020

Fixed in #945

@bmarty bmarty closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint9
Development

No branches or pull requests
2 participants
@bmarty @ganfra