Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when max shortcuts count is exceeded #8644

Merged
merged 2 commits into from Sep 13, 2023
Merged

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Sep 12, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add jvm argument to optimize app assembly
  • Fix crash when max shortcuts count is exceeded
  • Replace hardcoded app name in crash logs

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested a review from a team September 12, 2023 19:47
@yostyle yostyle self-assigned this Sep 12, 2023
@yostyle yostyle requested review from ganfra and removed request for a team September 12, 2023 19:47
@yostyle yostyle changed the title some fixes Fix crash when max shortcuts count is exceeded Sep 12, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, strange that we did not hear about this crash more often 🤔

@bmarty
Copy link
Member

bmarty commented Sep 13, 2023

Can you add a file for the changelog please?

@yostyle
Copy link
Contributor Author

yostyle commented Sep 13, 2023

LGTM, strange that we did not hear about this crash more often 🤔

we have this issue on Tchap tchapgouv/tchap-android#469 tchapgouv/tchap-android#964

@yostyle yostyle enabled auto-merge (squash) September 13, 2023 08:58
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@yostyle yostyle merged commit ff548d2 into develop Sep 13, 2023
17 checks passed
@yostyle yostyle deleted the yostyle/some_fixes branch September 13, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants