Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrossSigning / Update Shield Logic for DM #963

Closed
BillCarsonFr opened this issue Feb 5, 2020 · 2 comments · Fixed by #1181 or #1308
Closed

CrossSigning / Update Shield Logic for DM #963

BillCarsonFr opened this issue Feb 5, 2020 · 2 comments · Fixed by #1181 or #1308

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Feb 5, 2020

#see element-hq/element-web#12214

There are some cases where this doesn't happen today, e.g. if you have not verified one of your own devices, all rooms would go red (even large public rooms where you have no intention verifying users).

To make the experience more straightforward, we decided after chatting with @dbkr and @nadonomy to add the additional check that green / red states are only shown if you have verified at least one user in the room. If you haven't, the room is black.

Summary doc on shields: https://docs.google.com/document/d/1RFUN0YRrOs8QZwiblaUbs4wWR0BjA0hBJ27rKJ57Zvk/edit

@manuroe
Copy link
Member

manuroe commented Feb 5, 2020

Kamino cloned this issue to vector-im/riot-ios

@BillCarsonFr
Copy link
Member Author

BillCarsonFr commented Feb 24, 2020

DM

If you see a shield on a DM, you cognitively map that decoration to the other person only (I don't care about rooms, I just care about chatting with Alice. If I see a green tick on a DM with Alice, it's indicative of her and not me.)
So, it makes sense to abstract you away from a 1:1 DM

Group DM

From there, the same holds true of groups

@BillCarsonFr BillCarsonFr changed the title CrossSigning / Update Shield Logic CrossSigning / Update Shield Logic for DM Mar 26, 2020
@BillCarsonFr BillCarsonFr reopened this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants