Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new key agreement method for SAS #1374

Merged
merged 3 commits into from May 20, 2020
Merged

support new key agreement method for SAS #1374

merged 3 commits into from May 20, 2020

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented May 15, 2020

@BillCarsonFr BillCarsonFr requested a review from bmarty May 15, 2020 14:59
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick skim, it looks like it does the right thing, modulo my lack of kotlin knowledge.

BillCarsonFr and others added 2 commits May 19, 2020 09:55
…rnal/crypto/verification/DefaultVerificationService.kt

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit ca37895 into develop May 20, 2020
@bmarty bmarty deleted the feature/sas_v2 branch May 20, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants