Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/db clean up #1634

Merged
merged 11 commits into from
Jul 7, 2020
Merged

Feature/db clean up #1634

merged 11 commits into from
Jul 7, 2020

Conversation

ganfra
Copy link
Contributor

@ganfra ganfra commented Jul 6, 2020

This PR takes care of:

  • Cleaning chunks with lots of events as long as a threshold has been exceeded (35_000 events in DB)
  • Creating and listening to EventInsertEntity.
  • Handling (almost) properly the groups fetching

bmarty
bmarty approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a static review

@bmarty bmarty merged commit 9dc831d into develop Jul 7, 2020
@bmarty bmarty deleted the feature/db_clean_up branch July 7, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganfra @bmarty