Convert PushRuleService to suspend functions #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominic Fischer <dominicfischer7@gmail.com>
bmarty
reviewed
Nov 18, 2020
| } | ||
| .executeBy(taskExecutor) | ||
| override suspend fun removePushRule(kind: RuleKind, pushRule: PushRule) { | ||
| return removePushRuleTask.execute(RemovePushRuleTask.Params(kind, pushRule)) |
There was a problem hiding this comment.
In all those 4 methods, the return statement could be removed.
| result.onSuccess { | ||
| preference.setPushRule(ruleAndKind.copy(pushRule = newRule)) | ||
| } | ||
| hideLoadingView() |
There was a problem hiding this comment.
This is a detail, but now, I would rather call hideLoadingView() just after the check if Fragment is added.
There was a problem hiding this comment.
Technically the behaviour would be different (out of scope) but I'm not bothered if you're not bothered.
There was a problem hiding this comment.
Yes. I do not think it will introduce a bug if we reorder. Also we could use .fold() instead of onSuccess and onFailure which is a bit more verbose (but equivalent)
Signed-off-by: Dominic Fischer <dominicfischer7@gmail.com>
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dominic Fischer dominicfischer7@gmail.com
Pull Request Checklist