Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the status of send messages #2937

Merged
merged 18 commits into from
Mar 10, 2021
Merged

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Mar 1, 2021

@onurays onurays requested a review from bmarty March 4, 2021 11:31
@bmarty bmarty force-pushed the feature/ons/message_states branch from 8cc29a3 to 2496bc2 Compare March 9, 2021 15:05
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

android:layout_height="wrap_content"
android:layout_gravity="start"
android:layout_marginStart="8dp"
android:layout_marginEnd="@dimen/layout_horizontal_margin"
android:ellipsize="end"
android:fontFamily="sans-serif-bold"
android:singleLine="true"
android:textColor="?riotx_text_primary"
android:textColor="@color/riotx_accent"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a Figma with this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmarty bmarty force-pushed the feature/ons/message_states branch from 7905875 to fa40667 Compare March 10, 2021 10:10
@bmarty bmarty merged commit 8a1a90d into develop Mar 10, 2021
@bmarty bmarty deleted the feature/ons/message_states branch March 10, 2021 20:51
@bahur142
Copy link

I want to share a little bug from the new release regarding clip N2 "Read receipt state".
If the message is long and wide enough and the recipient read it, the message stretches itself to the right and goes behind the timestamp line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants