Permit cleartext for .onion addresses #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested changes
Mar 2, 2021
CHANGES.md
Outdated
| @@ -5,6 +5,7 @@ Features ✨: | |||
| - | |||
|
|
|||
| Improvements 🙌: | |||
| - Full compatibility with homeservers on Tor (#2941) | |||
There was a problem hiding this comment.
Can you change that to something more related to the actual change like Allow Element Android to connect to homeservers on Tor for instance?
There was a problem hiding this comment.
Changed it to "Allow non-HTTPS connections to homeservers on Tor". Does that work?
The Tor and Onion service protocols provide encryption and authentication respectively. Since Domain Validation certificates aren't currently being issued for .onion addresses, the HTTPS requirement makes Element practically incompatible with homeservers operated by individuals on Tor. Signed-off-by: Martin Häger <martin.haeger@gmail.com>
bmarty
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current network policy doesn't allow non-HTTPS connections to .onion addresses. Since Domain Validation certificates aren't currently being issued for .onion addresses, this requirement makes Element practically incompatible with homeservers operated by individuals on Tor. The Tor and Onion service protocols provide encryption and authentication respectively anyway, so HTTPS is typically redundant.
This PR adds an exception to the network policy for .onion addresses, so that the app can be used with e.g. Orbot.
Fixes #2931
Pull Request Checklist