Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused WebRTC dependency #8658

Merged
merged 2 commits into from Nov 7, 2023
Merged

Remove unused WebRTC dependency #8658

merged 2 commits into from Nov 7, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Oct 3, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove React-native-webrtc dependency. WebRTC library coming with jitsi-meet-sdk 8.1.1

Motivation and context

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team and bmarty and removed request for a team October 3, 2023 15:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ElementBot
Copy link

Warnings
⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0

⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0

⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0

⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0

⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

Generated by 🚫 dangerJS against b422f52

@yostyle yostyle enabled auto-merge (squash) October 4, 2023 15:05
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine if 1-1 call and Jitsi calls are tested OK. Can you confirm please?

@yostyle
Copy link
Contributor Author

yostyle commented Oct 19, 2023

It's fine if 1-1 call and Jitsi calls are tested OK. Can you confirm please?

Yes we tested 1-1 and Jitsi calls

@yostyle yostyle requested a review from bmarty October 23, 2023 15:55
@yostyle
Copy link
Contributor Author

yostyle commented Oct 23, 2023

Signed-off-by: yostyle y.pintas@gmail.com

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@yostyle yostyle merged commit b14338d into develop Nov 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants