Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with timeline message view reuse while rich text editor is enabled #8688

Merged
merged 2 commits into from Nov 17, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix issue with timeline message view reuse while Rich Text Editor (RTE) is enabled.

Motivation and context

Screenshots / GIFs

Tests

  • With RTE on, then with RTE off
    • In a room with some encryption messages
    • Send some messages
    • Scroll up and down the timeline
    • Observe the messages

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew marked this pull request as ready for review November 17, 2023 15:41
@jonnyandrew jonnyandrew requested review from a team and jmartinesp and removed request for a team November 17, 2023 15:42
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job at finding the cause!

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jonnyandrew jonnyandrew merged commit 63ef40f into develop Nov 17, 2023
18 checks passed
@jonnyandrew jonnyandrew deleted the jonny/fix-rte-timeline-view-reuse branch November 17, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected decryption state in the room timeline when WYSIWYG is enabled
2 participants