Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quote from message actions menu #8689

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Nov 17, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove the quote option from the message actions menu.

Motivation and context

To align with Element Web and Element iOS. In these clients, the quote option does not work together in conjunction with the rich text editor so it has been removed completely (whether the rich text editor is enabled or not).

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew marked this pull request as ready for review November 17, 2023 17:11
@jonnyandrew jonnyandrew requested review from a team and ganfra and removed request for a team November 17, 2023 17:12
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jonnyandrew jonnyandrew merged commit a6fafb0 into develop Nov 27, 2023
18 checks passed
@jonnyandrew jonnyandrew deleted the jonny/remove-quote-option branch November 27, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants