Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot join from a room preview for room with a long topic #1645

Closed
manuroe opened this issue Nov 8, 2017 · 1 comment
Closed

Cannot join from a room preview for room with a long topic #1645

manuroe opened this issue Nov 8, 2017 · 1 comment
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements user feedback
Milestone
Sprint 8

Comments

@manuroe
Copy link
Member

manuroe commented Nov 8, 2017 •
edited

This is impossible to join the mastodon room at https://matrix.to/#/#Mastodon-Social:matrix.org.

See https://matrix.to/#/!tDRGDwZwQnlkowsjsm:matrix.org/$15101609482693491SyGDj:matrix.org
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements P1 user feedback labels Nov 17, 2017
@giomfo giomfo mentioned this issue Nov 17, 2017
Closed
@giomfo
Copy link
Member

giomfo commented Nov 17, 2017

Aaron: "And rooms with multi-paragraph topics really need a “show more” button to expand them, because they’re pretty useless.
Also, I think links in the topic are unclickable."

(see https://matrix.to/#/!tDRGDwZwQnlkowsjsm:matrix.org/$15108492681177753KBlEp:matrix.org)

@manuroe manuroe added this to the Sprint 8 milestone Feb 19, 2018
@manuroe manuroe changed the title Bad display when trying to join a room with a long topic Cannot join from a room preview for room with a long topic Feb 28, 2018
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
9b6b71a 
Turn the room topic label into a text view to be able to scroll.
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
8c9c075 
Make sure the topic use all container width but keep it centered if the topic string is short
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
c5aab87 
If necessary, crop the room name in "You are trying to access %@. Would you like to join in order to participate in the discussion?" so that it does not eat all the screen.
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
3df7e19 
Update the room preview header height according to the screen height
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
c5d9957 
Topic textview: open it on the top of the topic text
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
c87be81 
Show the expanded room headers on iPad
@manuroe manuroe mentioned this issue Mar 12, 2018
Merged
manuroe added a commit that referenced this issue Mar 12, 2018
@manuroe
BF: Cannot join from a room preview for room with a long topic (#1645)
11378ea 
Follow Giom's remarks
@manuroe manuroe closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements user feedback
Projects
None yet
Milestone
Sprint 8
Development

No branches or pull requests
2 participants
@manuroe @giomfo