Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After a user redacted their own join event from HQ, Android DoSes us with /context requests #1730

Closed
ylecollen opened this issue Jan 10, 2018 · 0 comments
Closed

After a user redacted their own join event from HQ, Android DoSes us with /context requests #1730

ylecollen opened this issue Jan 10, 2018 · 0 comments
Assignees
@manuroe
Labels
P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint 8

Comments

@ylecollen
Copy link

see element-hq/riot-android#1859

The mobile clients used to call getContextOfEvent to check it is a room state event.

We should avoid using this request when we only need the event.
@giomfo giomfo self-assigned this Jan 10, 2018
@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements P2 P1 and removed P2 labels Jan 19, 2018
@manuroe manuroe added this to the Sprint 8 milestone Feb 19, 2018
@manuroe manuroe assigned manuroe and unassigned giomfo Mar 9, 2018
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Mar 9, 2018
@manuroe
MXRestClient: Add [MXRestClient eventWithEventId:] and [MXRestClient …
85ec5b9 
…eventWithEventId:inRoom:] methods

and use the last one to improve the handling of the redaction of an event so old that we do not have it the local store.

element-hq/element-ios#1730
@manuroe manuroe mentioned this issue Mar 9, 2018
Merged
@manuroe manuroe closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint 8
Development

No branches or pull requests
3 participants
@manuroe @giomfo @ylecollen