3D touching a link can lock the app

[manuroe]

Sometimes, 3D touching a link in a room can lock the app. The user needs to kill the app to use it again.

This happens at least in 2 manners:

• The peek view stays displayed. Stopping pressing should make the peek view go away but it sometimes stays on the top of screen with no way to come back to the app.
• After the pop (the user deeply pressed the link so that it has been opened in Safari), when the user reopens the app, the app displayed a blurry image of itself with no way to come back to a normal usage.

Peek and Pop doc:
https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/Adopting3DTouchOniPhone/index.html#//apple_ref/doc/uid/TP40016543-CH1-SW1

Screenshots:

[manuroe]

There is something in the app that makes peek and pork work badly but what?

The quickest fix is to disable 3D touch. It can be done by replacing https://github.com/matrix-org/matrix-ios-kit/blob/b49b3a0b6b3a6c213b29b62e09edaf0caa5792a2/MatrixKit/Views/RoomBubbleList/MXKRoomBubbleTableViewCell.m#L1189

by:

- (BOOL)textView:(UITextView *)textView shouldInteractWithURL:(nonnull NSURL *)URL inRange:(NSRange)characterRange interaction:(UITextItemInteraction)interaction
{
    BOOL shouldInteractWithURL = NO;
    if (@available(iOS 10.0, *))
    {
        if (interaction != UITextItemInteractionPreview)
        {
            shouldInteractWithURL = [self textView:textView shouldInteractWithURL:URL inRange:characterRange];
        }
    }

    return shouldInteractWithURL;
}

[manuroe]

Fixed by #2308.