Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lag in typing #1820

Closed
manuroe opened this issue Mar 23, 2018 · 3 comments
Closed

Lag in typing #1820

manuroe opened this issue Mar 23, 2018 · 3 comments
Assignees
@SBiOSoftWhare
Labels
P2 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems user feedback
Milestone
Sprint 11

Comments

@manuroe
Copy link
Member

manuroe commented Mar 23, 2018

Matthew has reported the issue several times.
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P2 user feedback P3 and removed P2 labels Mar 23, 2018
@manuroe
Copy link
Member Author

manuroe commented Mar 23, 2018

2 possible culprits in https://riot.im/bugreports/listing/2018-03-22/211057/console.log.gz of https://github.com/matrix-org/riot-ios-rageshakes/issues/1047 before
2018-03-22 21:10:28.596 Riot[6909:4885802] [RageShakeManager] Start shaking with [RoomViewController]:

  • unexpected series of
2018-03-22 21:10:23.782 Riot[6909:4885802] [MXFileStore commit] Background task #25265 started
2018-03-22 21:10:23.823 Riot[6909:4885802] [MXFileStore commit] lasted 41ms
2018-03-22 21:10:23.823 Riot[6909:4885802] [MXFileStore commit] Background task #25265 is complete - lasted 41ms
  • Some crypto operations maybe on the main thread: maybeUploadOneTimeKeys and generateOneTimeKeys

@manuroe
Copy link
Member Author

manuroe commented May 18, 2018

Another culprit could be the contact manager that makes things on the main thread.

SBiOSoftWhare added a commit to matrix-org/matrix-ios-kit that referenced this issue May 21, 2018
@SBiOSoftWhare
Logs: Add log for debugging local contacts refresh in MXKContactManager
7cf6ae1 
element-hq/element-ios#1820
SBiOSoftWhare added a commit to matrix-org/matrix-ios-kit that referenced this issue May 21, 2018
@SBiOSoftWhare
Logs: Add log for debugging keyboard show and hide
ca98429 
element-hq/element-ios#1820
@SBiOSoftWhare SBiOSoftWhare mentioned this issue May 21, 2018
Merged
@manuroe manuroe added this to the Sprint 11 milestone May 30, 2018
@manuroe manuroe added P2 and removed P3 labels May 30, 2018
@SBiOSoftWhare SBiOSoftWhare mentioned this issue Jun 7, 2018
Closed
@SBiOSoftWhare SBiOSoftWhare mentioned this issue Jun 27, 2018
Merged
@manuroe
Copy link
Member Author

manuroe commented Jul 3, 2018

Even if the app is still not perfect, recent perf improvements fix this issue.

@manuroe manuroe closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SBiOSoftWhare SBiOSoftWhare

Labels
P2 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems user feedback
Projects
None yet
Milestone
Sprint 11
Development

No branches or pull requests
2 participants
@SBiOSoftWhare @manuroe