Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to set an IS at login/registration #2661

Closed
jryans opened this issue Aug 16, 2019 · 2 comments
Closed

Remove the ability to set an IS at login/registration #2661

jryans opened this issue Aug 16, 2019 · 2 comments
Assignees
@manuroe
Labels
A-Identity-Server feature privacy privacy-sprint T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@jryans
Copy link
Contributor

jryans commented Aug 16, 2019

Cloned from element-hq/element-web#10553
@manuroe manuroe self-assigned this Aug 29, 2019
@manuroe
Copy link
Member

manuroe commented Aug 29, 2019 •
edited

We want to display only one field now, the field to configure a custom HS.
IS customisation should be no more part of the registration flow. But we need to manage old HSes.

The flow is:
1 - the user types their custom HS
2 - the app verifies if this HS needs an IS (riot-web does the request on the Next button)

Then, there are 2 paths:
3a- the answer is NO. The HS is up-to-date. Nothing more to set up.
4a- The user can now type their user name / pwd

3b- the answer is YES. The HS is old.
4b- the app shows the IS field and let the user customises it
5b- The user can now type their user name / pwd

@nadonomy
Copy link
Contributor

@manuroe this should suffice for those cases, using our existing styles/design language:

iOS - IS at registration

manuroe added a commit that referenced this issue Aug 30, 2019
@manuroe
Privacy: Remove the ability to set an IS at login/registration
571c3af 
#2661
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 30, 2019
@manuroe
Privacy: Remove the ability to set an IS at login/registration
0b98e14 
element-hq/element-ios/issues/2661
This was referenced Aug 30, 2019
Merged
Merged
Closed
@manuroe manuroe closed this as completed Aug 30, 2019
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-Identity-Server feature privacy privacy-sprint T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @jryans @nadonomy @manuroe