Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Improve the webview used for SSO #2715

Closed
4 tasks done
manuroe opened this issue Sep 13, 2019 · 0 comments
Closed
4 tasks done

Auth: Improve the webview used for SSO #2715

manuroe opened this issue Sep 13, 2019 · 0 comments
Milestone
Sprint 22

Comments

@manuroe
Copy link
Member

manuroe commented Sep 13, 2019 •
edited
Loading

This webview is also used as login and registration fallbacks.

TODO:

  • Replace the good old UIWebView by WKWebView
  • Support navigation. SSO can have several pages. We need a go back.
  • Spoof the webview UA to bypass OAuth provider limitation on webview usage like google
  • Make sure cookies are reset between each session
@manuroe manuroe added this to the Sprint 22 milestone Sep 13, 2019
manuroe added a commit that referenced this issue Sep 13, 2019
@manuroe
Authentication: Improve the webview used for SSO
0b9eb5d 
#2715
@manuroe manuroe mentioned this issue Sep 13, 2019
Merged
manuroe added a commit that referenced this issue Sep 13, 2019
@manuroe
Authentication: Improve the webview used for SSO
6d33a27 
#2715
@manuroe manuroe closed this as completed Sep 16, 2019
q3k added a commit to q3k/element-ios that referenced this issue Aug 25, 2020
@q3k
AuthenticationVC: fix connecting to homeservers that do not returns w…
4083d60 
…ell_known in their login response.

As per the Matrix spec, 5.5.2, Response Format, `well_known` is optional. The
current implementation fails completely (get stuck on loading screen because of
broken MXCredentials) in case Element interacts with such a homeserver. This
seems to have been broken in 17295a4, or, more
precisely, 6d33a27 / element-hq#2715.

This is a pretty nasty fix, as we use a random MXKAuthenticationViewController
method to grab the underlying MXRestClient to get the default credentials from.
I'm not sure how else to fix this, apart from maybe exposing a
defaultCredentials method in MXKAuthenticationVC. I'm not an Objective-C
developer :).
@q3k q3k mentioned this issue Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 22
Development

No branches or pull requests
1 participant
@manuroe